New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add night lights composites for ABI, AHI and AMI #1141
Conversation
Congratulations 🎉. DeepCode analyzed your code in 0.195 seconds and we found no issues. Enjoy a moment of no bugs ☀️. 👉 View analysis in DeepCode’s DashboardEdit DeepCode’s Configurations here |
Codecov Report
@@ Coverage Diff @@
## master #1141 +/- ##
=======================================
Coverage 89.60% 89.60%
=======================================
Files 200 200
Lines 29484 29484
=======================================
Hits 26420 26420
Misses 3064 3064
Continue to review full report at Codecov.
|
… modifications, SZA and rayleigh, for true_color and natural_color
I've just pushed a few more composites to this, which add a |
Codecov Report
@@ Coverage Diff @@
## master #1141 +/- ##
==========================================
+ Coverage 89.60% 89.80% +0.19%
==========================================
Files 200 204 +4
Lines 29484 30148 +664
==========================================
+ Hits 26420 27074 +654
- Misses 3064 3074 +10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple things came to mind, but otherwise looks good to me.
- The composites in
<instrument>.yaml
should IMHO use the channel names, and only the generic ones invisir.yaml
have wavelengths. This is debatable, so not strictly necessary here. But it would make things look more consistent and ensure the correct channels to be used. - As the
_nocorr
composites use reflectances, correction for the Sun-Earth distance should be needed as an modifier. We don't have that modifier yet, and it might need some reader-level metadata additions and checks, so not a problem here. For reference on reflectance/correction/modifier discussion: When is reflectance actually reflectance? #536
I've now, after a few failures, updated the YAML with @pnuu's request - the channels needed for the new composites are now specified by name. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added two suggested changes (one of which doesn't work with the current version). Otherwise LGTM.
Co-authored-by: Panu Lahtinen <pnuu+git@iki.fi>
This PR adds true color composites that use the VIIRS night lights as a background for night-time pixels. No code changes have been made, it simply re-uses the existing SEVIRI night lights composite (
natural_color_with_night_ir
). In the case of the new instruments, however, I chose to usetrue_color
instead ofnatural_color
to reflect the capabilities of the instruments.