Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add filepatterns S-HSAF-h03B and S-HSAF-h05B to hsaf_grib.yaml #1142

Merged
merged 4 commits into from Jun 1, 2020

Conversation

peters77
Copy link
Contributor

@peters77 peters77 commented Apr 13, 2020

Add the filepattern S-HSAF-h03B and S-HSAF-h05B as send by EUMETSAT/EUMETCAST.

  • Tests passed

@ghost
Copy link

ghost commented Apr 13, 2020

Congratulations 🎉. DeepCode analyzed your code in 0.001 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard

@coveralls
Copy link

coveralls commented Apr 13, 2020

Coverage Status

Coverage decreased (-0.003%) to 89.605% when pulling 0a589ad on peters77:wip-add-eum-grib-files into 446af3a on pytroll:master.

@peters77
Copy link
Contributor Author

Sorry...I won't do a Pull any more as I doesn't really know how this all works. I did a mistake and want to correct this, but it doesn't appear here.

So please if you review:
line 15 should be
'S-HSAF-h05B_{sensing_time:%Y%m%d_%H%M}_{accum_time:2s}_{region:3s}.grb']

and not!!!

'S-HSAF-h05B_{sensing_time:%Y%m%d_%H%M}_{region:3s}.grb']

Thank you! :-)

@codecov
Copy link

codecov bot commented Apr 13, 2020

Codecov Report

Merging #1142 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1142      +/-   ##
==========================================
- Coverage   89.60%   89.60%   -0.01%     
==========================================
  Files         200      200              
  Lines       29484    29484              
==========================================
- Hits        26420    26419       -1     
- Misses       3064     3065       +1     
Impacted Files Coverage Δ
satpy/scene.py 90.01% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 446af3a...0a589ad. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit d983421 into pytroll:master Jun 1, 2020
@mraspaud mraspaud added component:readers enhancement code enhancements, features, improvements labels Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants