Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cf writing of 3d arrays #1170

Merged
merged 2 commits into from May 13, 2020
Merged

Fix cf writing of 3d arrays #1170

merged 2 commits into from May 13, 2020

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Apr 30, 2020

This is a fix for a bug discovered yesterday by @TAlonglong : the CF writer wasn't able to write images, because of the chunks handling when converting an area to lons and lats.

  • Tests added
  • Tests passed
  • Passes flake8 satpy

@coveralls
Copy link

coveralls commented Apr 30, 2020

Coverage Status

Coverage decreased (-0.009%) to 89.596% when pulling b5bd072 on mraspaud:fix-cf-images into 65cd83f on pytroll:master.

@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #1170 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1170   +/-   ##
=======================================
  Coverage   89.60%   89.60%           
=======================================
  Files         200      200           
  Lines       29487    29499   +12     
=======================================
+ Hits        26422    26434   +12     
  Misses       3065     3065           
Impacted Files Coverage Δ
satpy/tests/writer_tests/test_cf.py 98.57% <100.00%> (+0.03%) ⬆️
satpy/writers/cf_writer.py 93.77% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65cd83f...b5bd072. Read the comment docs.

@djhoese
Copy link
Member

djhoese commented May 7, 2020

@mraspaud Let me know if this is ready to merge (you can merge it if it is ready). I have a colleague who just ran in to this.

@mraspaud mraspaud merged commit 7d950d2 into pytroll:master May 13, 2020
@mraspaud
Copy link
Member Author

@djhoese merged!

@mraspaud mraspaud deleted the fix-cf-images branch May 13, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants