Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check whether time dimension exists for timeseries #1173

Merged
merged 4 commits into from Jun 9, 2020

Conversation

zxdawn
Copy link
Member

@zxdawn zxdawn commented May 1, 2020

If time dimension exists, we can blend them directly.

  • Tests added
  • Tests passed
  • Passes flake8 satpy
  • Fully documented
  • Add your name to AUTHORS.md if not there already

@coveralls
Copy link

coveralls commented May 1, 2020

Coverage Status

Coverage increased (+0.4%) to 89.956% when pulling 0c04bf7 on zxdawn:multiscene into 65cd83f on pytroll:master.

@codecov
Copy link

codecov bot commented May 1, 2020

Codecov Report

Merging #1173 into master will increase coverage by 0.34%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1173      +/-   ##
==========================================
+ Coverage   89.60%   89.95%   +0.34%     
==========================================
  Files         200      208       +8     
  Lines       29484    30596    +1112     
==========================================
+ Hits        26420    27523    +1103     
- Misses       3064     3073       +9     
Impacted Files Coverage Δ
satpy/multiscene.py 89.63% <100.00%> (+0.30%) ⬆️
satpy/tests/test_multiscene.py 99.39% <100.00%> (+0.13%) ⬆️
satpy/readers/tropomi_l2.py 87.06% <0.00%> (-2.94%) ⬇️
satpy/readers/avhrr_l1b_gaclac.py 93.33% <0.00%> (-1.34%) ⬇️
satpy/readers/viirs_compact.py 64.12% <0.00%> (-1.27%) ⬇️
satpy/readers/hrit_jma.py 97.94% <0.00%> (-1.22%) ⬇️
satpy/tests/test_composites.py 99.88% <0.00%> (-0.12%) ⬇️
satpy/writers/cf_writer.py 93.77% <0.00%> (-0.03%) ⬇️
satpy/writers/geotiff.py 90.74% <0.00%> (ø)
satpy/tests/test_dataset.py 100.00% <0.00%> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 446af3a...0c04bf7. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do we haves tests for multiscene? In which case a small test for this would be nice to have

@zxdawn
Copy link
Member Author

zxdawn commented Jun 4, 2020

@mraspaud I've added the test to the part of test_timeseries in test_multiscene.py.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zxdawn
Copy link
Member Author

zxdawn commented Jun 9, 2020

@djhoese Is this PR fine enough?

@mraspaud
Copy link
Member

mraspaud commented Jun 9, 2020

@zxdawn Sorry I forgot to merge this.

@mraspaud mraspaud merged commit 7413392 into pytroll:master Jun 9, 2020
@mraspaud mraspaud added component:multiscene enhancement code enhancements, features, improvements labels Jun 9, 2020
@zxdawn zxdawn deleted the multiscene branch June 9, 2020 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:multiscene enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants