New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide platform_name in FCI L1C FDHSI reader. #1176
Conversation
In the FCI L1C FDHSI reader, provide the platform name as MTG-I1, MTG-I2, MTG-I3, or MTG-I4, corresponding to the acronyms used by the WMO OSCAR database. The reader translates those from the global NetCDF attribute `platform` provided in each file, where it has the value "MTI1" in the currently available test data.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Indeed, we will see how the satellites are numbered after commissioning.
Codecov Report
@@ Coverage Diff @@
## master #1176 +/- ##
=======================================
Coverage 89.60% 89.61%
=======================================
Files 200 200
Lines 29487 29504 +17
=======================================
+ Hits 26422 26439 +17
Misses 3065 3065
Continue to review full report at Codecov.
|
Good question. I never really got the magic what happens on these sites. |
@mraspaud I had deleted my comment to which you just replied because coveralls changed its mind and concluded the coverage increased (note the edit in the comment by coveralls). |
In the FCI L1C FDHSI reader, provide the platform name as MTG-I1,
MTG-I2, MTG-I3, or MTG-I4, corresponding to the acronyms used by the WMO
OSCAR database. The reader translates those from the global NetCDF
attribute
platform
provided in each file, where it has the value"MTI1" in the currently available test data.
platform_name
in the attributes #1014flake8 satpy