Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide platform_name in FCI L1C FDHSI reader. #1176

Merged
merged 1 commit into from May 4, 2020

Conversation

gerritholl
Copy link
Collaborator

@gerritholl gerritholl commented May 4, 2020

In the FCI L1C FDHSI reader, provide the platform name as MTG-I1,
MTG-I2, MTG-I3, or MTG-I4, corresponding to the acronyms used by the WMO
OSCAR database. The reader translates those from the global NetCDF
attribute platform provided in each file, where it has the value
"MTI1" in the currently available test data.

In the FCI L1C FDHSI reader, provide the platform name as MTG-I1,
MTG-I2, MTG-I3, or MTG-I4, corresponding to the acronyms used by the WMO
OSCAR database.  The reader translates those from the global NetCDF
attribute `platform` provided in each file, where it has the value
"MTI1" in the currently available test data.
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Indeed, we will see how the satellites are numbered after commissioning.

@mraspaud mraspaud added this to In progress in PCW Spring 2020 May 4, 2020
@coveralls
Copy link

coveralls commented May 4, 2020

Coverage Status

Coverage increased (+0.006%) to 89.612% when pulling 512a3d8 on gerritholl:fci-platform-name into 65cd83f on pytroll:master.

@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #1176 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1176   +/-   ##
=======================================
  Coverage   89.60%   89.61%           
=======================================
  Files         200      200           
  Lines       29487    29504   +17     
=======================================
+ Hits        26422    26439   +17     
  Misses       3065     3065           
Impacted Files Coverage Δ
satpy/readers/fci_l1c_fdhsi.py 96.21% <100.00%> (+0.05%) ⬆️
satpy/tests/reader_tests/test_fci_l1c_fdhsi.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65cd83f...512a3d8. Read the comment docs.

@gerritholl gerritholl moved this from In progress to Ready for review in PCW Spring 2020 May 4, 2020
@mraspaud
Copy link
Member

mraspaud commented May 4, 2020

Good question. I never really got the magic what happens on these sites.

@gerritholl
Copy link
Collaborator Author

@mraspaud I had deleted my comment to which you just replied because coveralls changed its mind and concluded the coverage increased (note the edit in the comment by coveralls).

@mraspaud mraspaud added component:readers enhancement code enhancements, features, improvements labels May 4, 2020
@mraspaud mraspaud merged commit a82e4a6 into pytroll:master May 4, 2020
PCW Spring 2020 automation moved this from Ready for review to Done May 4, 2020
@gerritholl gerritholl deleted the fci-platform-name branch May 4, 2020 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Development

Successfully merging this pull request may close these issues.

The fci_l1c_fdhsi reader should proved the platform_name in the attributes
3 participants