Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add options for creating geotiff overviews #1183

Merged
merged 2 commits into from May 6, 2020

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented May 5, 2020

Adds the additional keyword arguments necessary to take advantage of trollimage's new overviews functionality. See pytroll/trollimage#67.

The basic overviews functionality has existed for a while, but this keyword argument was never actually passed to trollimage. Not sure who was using overviews, but I don't think it ever worked.

Given this is just kwargs, do I need to add tests?

  • Tests added
  • Tests passed
  • Passes flake8 satpy
  • Fully documented

@djhoese djhoese added enhancement code enhancements, features, improvements component:writers labels May 5, 2020
@djhoese djhoese requested a review from mraspaud as a code owner May 5, 2020 21:19
@djhoese djhoese self-assigned this May 5, 2020
@djhoese djhoese added this to To do in PCW Spring 2020 via automation May 5, 2020
@coveralls
Copy link

coveralls commented May 5, 2020

Coverage Status

Coverage decreased (-0.003%) to 89.615% when pulling ae4aea5 on djhoese:feature-geotiff-overviews into ef24f29 on pytroll:master.

@codecov
Copy link

codecov bot commented May 5, 2020

Codecov Report

Merging #1183 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1183      +/-   ##
==========================================
- Coverage   89.61%   89.61%   -0.01%     
==========================================
  Files         200      200              
  Lines       29522    29523       +1     
==========================================
  Hits        26457    26457              
- Misses       3065     3066       +1     
Impacted Files Coverage Δ
satpy/writers/geotiff.py 90.74% <ø> (ø)
satpy/scene.py 90.01% <0.00%> (-0.18%) ⬇️
satpy/tests/reader_tests/test_fci_l1c_fdhsi.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79ea923...ae4aea5. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I suppose it doesn't make sense to add a test?

satpy/writers/geotiff.py Show resolved Hide resolved
@djhoese
Copy link
Member Author

djhoese commented May 6, 2020

I'm going to say no on the tests. Merging now...

@djhoese djhoese merged commit 2b7fdd4 into pytroll:master May 6, 2020
PCW Spring 2020 automation moved this from To do to Done May 6, 2020
@djhoese djhoese deleted the feature-geotiff-overviews branch May 6, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:writers enhancement code enhancements, features, improvements
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants