New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add satpy cf reader #1205
Add satpy cf reader #1205
Conversation
Signed-off-by: Martin Raspaud <martin.raspaud@smhi.se>
Congratulations 🎉. DeepCode analyzed your code in 2.01 seconds and we found no issues. Enjoy a moment of no bugs ☀️. 👉 View analysis in DeepCode’s Dashboard |
ds_info['modifiers'] = tuple(ds_info['modifiers'].split(' ')) | ||
except AttributeError: | ||
pass | ||
except KeyError: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
except (AttributError, KeyError):
or is this doing something special?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the most indented try shouldn't be needed if we fix the cf writer, so it's not supposed to be there. But yeah, I wanted to distinguish the two errors for now. The KeyError is ok, the AttributeError shouldn't happen at all...
Codecov Report
@@ Coverage Diff @@
## master #1205 +/- ##
==========================================
- Coverage 89.60% 89.49% -0.11%
==========================================
Files 200 201 +1
Lines 29487 29740 +253
==========================================
+ Hits 26422 26617 +195
- Misses 3065 3123 +58
Continue to review full report at Codecov.
|
This adds a reader for satpy's own cf files.
flake8 satpy
AUTHORS.md
if not there already