Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add satpy cf reader #1205

Closed
wants to merge 2 commits into from
Closed

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented May 13, 2020

This adds a reader for satpy's own cf files.

Signed-off-by: Martin Raspaud <martin.raspaud@smhi.se>
@mraspaud mraspaud added enhancement code enhancements, features, improvements help wanted component:readers labels May 13, 2020
@mraspaud mraspaud self-assigned this May 13, 2020
@ghost
Copy link

ghost commented May 13, 2020

Congratulations 🎉. DeepCode analyzed your code in 2.01 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard

ds_info['modifiers'] = tuple(ds_info['modifiers'].split(' '))
except AttributeError:
pass
except KeyError:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

except (AttributError, KeyError): or is this doing something special?

Copy link
Member Author

@mraspaud mraspaud May 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the most indented try shouldn't be needed if we fix the cf writer, so it's not supposed to be there. But yeah, I wanted to distinguish the two errors for now. The KeyError is ok, the AttributeError shouldn't happen at all...

@coveralls
Copy link

coveralls commented May 13, 2020

Coverage Status

Coverage decreased (-0.2%) to 89.499% when pulling f3ad83f on mraspaud:feature-satpy-cf-reader into b8bd9ab on pytroll:master.

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #1205 into master will decrease coverage by 0.10%.
The diff coverage is 25.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1205      +/-   ##
==========================================
- Coverage   89.60%   89.49%   -0.11%     
==========================================
  Files         200      201       +1     
  Lines       29487    29740     +253     
==========================================
+ Hits        26422    26617     +195     
- Misses       3065     3123      +58     
Impacted Files Coverage Δ
satpy/readers/satpy_cf_nc.py 25.71% <25.71%> (ø)
satpy/readers/avhrr_l1b_gaclac.py 93.33% <0.00%> (-1.34%) ⬇️
satpy/readers/hrit_jma.py 97.94% <0.00%> (-1.22%) ⬇️
satpy/readers/yaml_reader.py 95.30% <0.00%> (-0.13%) ⬇️
satpy/writers/cf_writer.py 93.77% <0.00%> (-0.03%) ⬇️
satpy/writers/geotiff.py 90.74% <0.00%> (ø)
satpy/readers/netcdf_utils.py 100.00% <0.00%> (ø)
satpy/readers/seviri_l1b_native.py 71.96% <0.00%> (ø)
satpy/tests/reader_tests/test_ahi_hrit.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_fci_l1c_fdhsi.py 100.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65cd83f...f3ad83f. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements help wanted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

satpy to support reading of satpy generated netcdf cf files
3 participants