Fix "rows_per_scan" not being available from VIIRS SDR readers #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah turns out I didn't have pre-commit installed on my current environment. Will try now. |
mraspaud
approved these changes
May 22, 2020
|
👉 View analysis in DeepCode’s Dashboard |
djhoese
changed the title
|
Done |
|
Got the OK from Martin on slack. Merging (appveyor is passing but the notification didn't make it all the way to github apparently). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "rows_per_scan" piece of metadata used to be in this reader (I'm 90% sure), but somewhere along the line it disappeared. This PR adds it back in. It's also possible it is in viirs_l1b and maybe the compact reader but never got added to this reader. Anyway...should be fixed now with tests to check for it.
flake8 satpyI checked the flake8 line because I didn't get a warning from pre-commit, but I'm also pretty sure some of the docstrings are wrong. Maybe it isn't checking the full file anymore?