Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VII L1b netCDF-reader. #1218

Merged
merged 10 commits into from Jun 8, 2020
Merged

Add VII L1b netCDF-reader. #1218

merged 10 commits into from Jun 8, 2020

Conversation

sjoro
Copy link
Collaborator

@sjoro sjoro commented May 26, 2020

Add EPS-SG VII L1b netCDF reader. Replaces PR #1069 and is based on a most recent master-branch.

  • Tests added
  • Tests passed
  • Passes flake8 satpy
  • Fully documented

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, provided vii_base_nc is fixed according to the comments in #1219

@sjoro sjoro marked this pull request as ready for review June 4, 2020 14:35
@sjoro sjoro requested a review from djhoese as a code owner June 4, 2020 14:35
@coveralls
Copy link

coveralls commented Jun 5, 2020

Coverage Status

Coverage increased (+0.1%) to 90.031% when pulling a0aff96 on sjoro:vii_l1b into 5bf9235 on pytroll:master.

@mraspaud
Copy link
Member

mraspaud commented Jun 8, 2020

try to trigger travis

@mraspaud mraspaud closed this Jun 8, 2020
@mraspaud mraspaud reopened this Jun 8, 2020
@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #1218 into master will increase coverage by 0.09%.
The diff coverage is 97.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1218      +/-   ##
==========================================
+ Coverage   89.93%   90.03%   +0.09%     
==========================================
  Files         210      216       +6     
  Lines       30792    31197     +405     
==========================================
+ Hits        27692    28087     +395     
- Misses       3100     3110      +10     
Impacted Files Coverage Δ
satpy/readers/vii_l1b_nc.py 96.07% <96.07%> (ø)
satpy/tests/reader_tests/test_vii_l1b_nc.py 97.18% <97.18%> (ø)
satpy/tests/reader_tests/test_vii_base_nc.py 97.46% <97.46%> (ø)
satpy/readers/vii_base_nc.py 97.89% <97.89%> (ø)
satpy/readers/netcdf_utils.py 100.00% <100.00%> (ø)
satpy/readers/vii_utils.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_netcdf_utils.py 95.60% <100.00%> (+0.14%) ⬆️
satpy/tests/reader_tests/test_vii_utils.py 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bf9235...a0aff96. Read the comment docs.

@mraspaud mraspaud merged commit 8cfb5df into pytroll:master Jun 8, 2020
@mraspaud mraspaud added component:readers enhancement code enhancements, features, improvements labels Jun 8, 2020
@sjoro sjoro deleted the vii_l1b branch June 8, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants