Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cf_writer supports array type in attrs #1245

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

zxdawn
Copy link
Member

@zxdawn zxdawn commented Jun 29, 2020

If the attribute type is array, the cf_writer could cause the error which is similar to #1243 .

  • Tests added
  • Tests passed
  • Passes flake8 satpy

@zxdawn zxdawn requested a review from mraspaud as a code owner June 29, 2020 11:17
@coveralls
Copy link

coveralls commented Jun 29, 2020

Coverage Status

Coverage decreased (-0.003%) to 90.024% when pulling 1088d8f on zxdawn:cf_writer into 9261a1c on pytroll:master.

@codecov
Copy link

codecov bot commented Jun 29, 2020

Codecov Report

Merging #1245 into master will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1245      +/-   ##
==========================================
- Coverage   90.02%   90.02%   -0.01%     
==========================================
  Files         218      218              
  Lines       31263    31265       +2     
==========================================
+ Hits        28145    28146       +1     
- Misses       3118     3119       +1     
Impacted Files Coverage Δ
satpy/writers/cf_writer.py 93.47% <50.00%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9261a1c...1088d8f. Read the comment docs.

satpy/writers/cf_writer.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants