Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update safe_msi for new pyproj compatibility #1259

Merged
merged 2 commits into from Jul 20, 2020

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Jul 15, 2020

  • Tests passed
  • Passes flake8 satpy

@coveralls
Copy link

coveralls commented Jul 15, 2020

Coverage Status

Coverage decreased (-0.02%) to 90.02% when pulling 5d6bc92 on mraspaud:fix-safe-msi into 3128bf5 on pytroll:master.

@mraspaud mraspaud requested a review from djhoese July 15, 2020 13:12
@mraspaud
Copy link
Member Author

I know this isn't tested, but tests are coming in a later PR (including switch from glymur to rasterio possibly)

@codecov
Copy link

codecov bot commented Jul 15, 2020

Codecov Report

Merging #1259 into master will decrease coverage by 0.01%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1259      +/-   ##
==========================================
- Coverage   90.03%   90.01%   -0.02%     
==========================================
  Files         218      218              
  Lines       31275    31282       +7     
==========================================
+ Hits        28159    28160       +1     
- Misses       3116     3122       +6     
Impacted Files Coverage Δ
satpy/readers/msi_safe.py 2.29% <12.50%> (-0.13%) ⬇️
satpy/scene.py 90.22% <0.00%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3128bf5...5d6bc92. Read the comment docs.

@mraspaud
Copy link
Member Author

@djhoese any comments?

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a hard requirement on pyproj 2.0+? If so then LGTM.

@mraspaud
Copy link
Member Author

Do we have a hard requirement on pyproj 2.0+? If so then LGTM.

We don't, so I have to fix this.

@mraspaud mraspaud merged commit 4a1231e into pytroll:master Jul 20, 2020
@mraspaud mraspaud deleted the fix-safe-msi branch August 17, 2021 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants