Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor scene to privatize some attributes and methods #1300

Merged
merged 1 commit into from Aug 6, 2020

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Aug 6, 2020

This PR privatise some attributes and methods of the Scene class

  • Tests passed
  • Passes flake8 satpy

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 89.986% when pulling e8f2218 on mraspaud:feature-privatize-scene-items into b86b2f7 on pytroll:master.

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #1300 into master will increase coverage by 0.00%.
The diff coverage is 98.17%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1300   +/-   ##
=======================================
  Coverage   89.98%   89.98%           
=======================================
  Files         219      219           
  Lines       32101    32106    +5     
=======================================
+ Hits        28885    28891    +6     
+ Misses       3216     3215    -1     
Impacted Files Coverage Δ
satpy/scene.py 90.51% <95.04%> (+0.23%) ⬆️
satpy/multiscene.py 90.62% <100.00%> (+0.02%) ⬆️
satpy/tests/reader_tests/test_iasi_l2_so2_bufr.py 97.18% <100.00%> (ø)
satpy/tests/reader_tests/test_modis_l2.py 98.18% <100.00%> (ø)
satpy/tests/test_scene.py 99.72% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b86b2f7...e8f2218. Read the comment docs.

@mraspaud mraspaud merged commit c6aa532 into pytroll:master Aug 6, 2020
@mraspaud mraspaud deleted the feature-privatize-scene-items branch August 6, 2020 19:18
@djhoese djhoese changed the title Refactor scene to privatise some attributes and methods Refactor scene to privatize some attributes and methods Aug 6, 2020
@djhoese djhoese added the backwards-incompatibility Causes backwards incompatibility or introduces a deprecation label Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backwards-incompatibility Causes backwards incompatibility or introduces a deprecation component:scene refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants