Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pad_data functionality to FCI L1c FDHSI reader #1310

Merged
merged 6 commits into from Aug 11, 2020

Conversation

ameraner
Copy link
Member

@ameraner ameraner commented Aug 10, 2020

This PR plugs the fci_l1c_fdhsi reader into the GEOSegmentYAMLReader. With this, missing chunks (aka segments) are padded with nans using the scn.load([ds_name], pad_data=True) mechanism.

After switching to the GEOSegmentYAMLReader, the FCI tests were failing due to issues with the "hackyness" in the TestGEOSegmentYAMLReader. This was solved using the same unittest patch methods implemented in #1194.

  • Tests added
  • Tests passed
  • Passes flake8 satpy

@codecov
Copy link

codecov bot commented Aug 10, 2020

Codecov Report

Merging #1310 into master will increase coverage by 0.06%.
The diff coverage is 98.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1310      +/-   ##
==========================================
+ Coverage   89.98%   90.04%   +0.06%     
==========================================
  Files         219      220       +1     
  Lines       32105    32364     +259     
==========================================
+ Hits        28889    29143     +254     
- Misses       3216     3221       +5     
Impacted Files Coverage Δ
satpy/readers/yaml_reader.py 95.23% <95.00%> (-0.07%) ⬇️
satpy/tests/reader_tests/test_fci_l1c_fdhsi.py 100.00% <100.00%> (ø)
satpy/tests/test_yaml_reader.py 99.83% <100.00%> (+0.02%) ⬆️
satpy/tests/reader_tests/test_ami_l1b.py 96.29% <0.00%> (-0.90%) ⬇️
satpy/node.py 94.48% <0.00%> (-0.36%) ⬇️
satpy/tests/test_scene.py 99.72% <0.00%> (-0.01%) ⬇️
satpy/tests/test_dataset.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_utils.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_ahi_hsd.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_iasi_l2_so2_bufr.py 97.18% <0.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 367d725...118fd36. Read the comment docs.

@coveralls
Copy link

coveralls commented Aug 10, 2020

Coverage Status

Coverage increased (+0.03%) to 90.048% when pulling 118fd36 on ameraner:feature-padding_support_fci_reader into 4924cba on pytroll:master.

satpy/readers/yaml_reader.py Outdated Show resolved Hide resolved
@ameraner ameraner marked this pull request as ready for review August 11, 2020 13:23
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 26fd1f9 into pytroll:master Aug 11, 2020
@ameraner
Copy link
Member Author

Thanks a lot for the reviews and the merge!

@ameraner ameraner deleted the feature-padding_support_fci_reader branch December 7, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants