New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pad_data functionality to FCI L1c FDHSI reader #1310
Add pad_data functionality to FCI L1c FDHSI reader #1310
Conversation
…e method used in the tests of the GEOFlippableFileYamlreader
Codecov Report
@@ Coverage Diff @@
## master #1310 +/- ##
==========================================
+ Coverage 89.98% 90.04% +0.06%
==========================================
Files 219 220 +1
Lines 32105 32364 +259
==========================================
+ Hits 28889 29143 +254
- Misses 3216 3221 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks a lot for the reviews and the merge! |
This PR plugs the
fci_l1c_fdhsi
reader into theGEOSegmentYAMLReader
. With this, missing chunks (aka segments) are padded with nans using thescn.load([ds_name], pad_data=True)
mechanism.After switching to the
GEOSegmentYAMLReader
, the FCI tests were failing due to issues with the "hackyness" in theTestGEOSegmentYAMLReader
. This was solved using the same unittest patch methods implemented in #1194.flake8 satpy