Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix true colors generation for AHI HSD data and refactor the dep tree code #1313

Merged
merged 12 commits into from Sep 1, 2020

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Aug 14, 2020

Refactor the dep tree code and fix the true color composite for instruments with channels at different resolutions.

  • Tests added
  • Tests passed
  • Passes flake8 satpy
  • Fully documented

@ghost
Copy link

ghost commented Aug 14, 2020

Congratulations 🎉. DeepCode analyzed your code in 2.918 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@coveralls
Copy link

coveralls commented Aug 14, 2020

Coverage Status

Coverage increased (+0.2%) to 90.241% when pulling 9fdbd7a on mraspaud:fix-true-color-ahi into cdc8ce5 on pytroll:master.

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #1313 into master will increase coverage by 0.17%.
The diff coverage is 97.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1313      +/-   ##
==========================================
+ Coverage   90.06%   90.24%   +0.17%     
==========================================
  Files         220      222       +2     
  Lines       32419    32719     +300     
==========================================
+ Hits        29198    29526     +328     
+ Misses       3221     3193      -28     
Impacted Files Coverage Δ
satpy/__init__.py 86.66% <ø> (+0.95%) ⬆️
satpy/tests/utils.py 95.40% <ø> (ø)
satpy/dataset.py 93.07% <91.30%> (+0.14%) ⬆️
satpy/dependency_tree.py 97.26% <97.26%> (ø)
satpy/node.py 86.36% <100.00%> (-8.12%) ⬇️
satpy/readers/yaml_reader.py 95.23% <100.00%> (ø)
satpy/scene.py 90.58% <100.00%> (+0.06%) ⬆️
satpy/tests/test_dataset.py 100.00% <100.00%> (ø)
satpy/tests/test_dependency_tree.py 100.00% <100.00%> (ø)
satpy/tests/test_node.py 100.00% <100.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdc8ce5...9fdbd7a. Read the comment docs.

@mraspaud mraspaud marked this pull request as ready for review August 21, 2020 11:50
@mraspaud mraspaud requested a review from djhoese as a code owner August 21, 2020 11:50
@mraspaud mraspaud changed the title Refactor the dep tree code Fix true colors generation for AHI HSD data and refactor the dep tree code Aug 21, 2020
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this transitive change on resolution you'll need to update the dev guide docs which use resolution as an example.

I also don't use transitive in my everyday vocabulary (I don't have a very large one) but I'm confused at which definition of transitive fits here with how it is being used.

@mraspaud
Copy link
Member Author

mraspaud commented Aug 24, 2020

The idea is that if the compositor C needs dependency D1 with property P with value V, and D1 depends on D2, then D2 should have property P with value V also (if applicable). Indeed, this isn't strict transitivity, but I couldn't come up with a better name for it. Suggestions are welcome.

For example full MODIS datasets provide the same data at multiple resolution. The right resolution has to be used if the user has requested a specific resolution.
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong with this. I'm sure there will be surprises, but better to have more things working and getting towards a fully working redesign/refactor. I had one comment about the new exception but otherwise I'll just ask for a self-review of the new methods you added to everything and make sure that they actually need to be public. Otherwise LGTM.

satpy/node.py Show resolved Hide resolved
@mraspaud
Copy link
Member Author

mraspaud commented Sep 1, 2020

I think things are in order with public/private

@mraspaud mraspaud merged commit 280d863 into pytroll:master Sep 1, 2020
@mraspaud mraspaud deleted the fix-true-color-ahi branch September 1, 2020 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants