Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in variable names in resample documentation #1317

Merged
merged 1 commit into from
Aug 19, 2020

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Aug 18, 2020

The variable says "global_scene" but is actually "scn". Not sure how/when this happened, but this PR fixes it.

  • Closes #xxxx
  • Tests added
  • Tests passed
  • Passes flake8 satpy
  • Fully documented

@djhoese djhoese self-assigned this Aug 18, 2020
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.065% when pulling 0fe675b on djhoese:doc-resample-typo into e0773c4 on pytroll:master.

@codecov
Copy link

codecov bot commented Aug 18, 2020

Codecov Report

Merging #1317 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1317   +/-   ##
=======================================
  Coverage   90.06%   90.06%           
=======================================
  Files         220      220           
  Lines       32420    32420           
=======================================
  Hits        29199    29199           
  Misses       3221     3221           
Impacted Files Coverage Δ
satpy/resample.py 90.77% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0773c4...0fe675b. Read the comment docs.

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djhoese djhoese merged commit 452f8ad into pytroll:master Aug 19, 2020
@djhoese djhoese deleted the doc-resample-typo branch August 19, 2020 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants