Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NIRReflectance passing None as sunz_threshold #1319

Merged
merged 5 commits into from
Aug 21, 2020

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Aug 20, 2020

The documentation of the NIRReflectance compositor says about the sunz_threshold parameter:

Default None, in which case the default threshold defined in Pyspectral will be used.

This wasn't the case, and wasn't tested. This PR fixes the behaviour and adds a test for it.

  • Tests added
  • Tests passed
  • Passes flake8 satpy
  • Fully documented

@mraspaud mraspaud self-assigned this Aug 20, 2020
@mraspaud mraspaud requested a review from adybbroe August 20, 2020 06:57
@mraspaud mraspaud added the bug label Aug 20, 2020
@coveralls
Copy link

coveralls commented Aug 20, 2020

Coverage Status

Coverage increased (+0.02%) to 90.081% when pulling 825a39c on mraspaud:fix-near-refl into 452f8ad on pytroll:master.

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #1319 into master will increase coverage by 0.01%.
The diff coverage is 97.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1319      +/-   ##
==========================================
+ Coverage   90.06%   90.08%   +0.01%     
==========================================
  Files         220      220              
  Lines       32420    32472      +52     
==========================================
+ Hits        29199    29251      +52     
  Misses       3221     3221              
Impacted Files Coverage Δ
satpy/composites/__init__.py 81.32% <94.44%> (+0.48%) ⬆️
satpy/tests/test_composites.py 99.89% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 452f8ad...825a39c. Read the comment docs.

@mraspaud mraspaud marked this pull request as ready for review August 20, 2020 09:37
@mraspaud mraspaud requested a review from djhoese as a code owner August 20, 2020 09:37
Copy link
Contributor

@adybbroe adybbroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Very nice with the refactoring!

@mraspaud mraspaud merged commit 9ef1086 into pytroll:master Aug 21, 2020
@mraspaud mraspaud deleted the fix-near-refl branch August 21, 2020 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants