-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix NIRReflectance passing None as sunz_threshold #1319
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1319 +/- ##
==========================================
+ Coverage 90.06% 90.08% +0.01%
==========================================
Files 220 220
Lines 32420 32472 +52
==========================================
+ Hits 29199 29251 +52
Misses 3221 3221
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Very nice with the refactoring!
The documentation of the NIRReflectance compositor says about the
sunz_threshold
parameter:This wasn't the case, and wasn't tested. This PR fixes the behaviour and adds a test for it.
flake8 satpy