New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use nbviewer for linking notebooks. #1325
Conversation
When linking to jupyter notebooks from the Satpy documentation, add a direct link to nbviewer rather than to Github. Github often fails to render notebooks.
Codecov Report
@@ Coverage Diff @@
## master #1325 +/- ##
=======================================
Coverage 90.13% 90.13%
=======================================
Files 220 220
Lines 32512 32512
=======================================
Hits 29305 29305
Misses 3207 3207 Continue to review full report at Codecov.
|
Did you check that they all render correctly in nbviewer? Iirc I had cases where Github would render better than nbviewer, depending on where the images we're hosted |
No, I didn't check if they all render correctly in nbviewer. Considering that none of them render anything in Github at all, any rendering is better than none. |
We've discussed the possibility of a generated gallery indeed, but haven't found a solution yet |
Until we have that, I think viewing the notebooks with most images missing (such as this PR) is still an improvement to not being able to view them at all (in my experience, Github viewing of notebooks almost never works). |
When linking to jupyter notebooks from the Satpy documentation, add a
direct link to nbviewer rather than to Github. Github often fails to
render notebooks.