Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nbviewer for linking notebooks. #1325

Merged
merged 1 commit into from Sep 9, 2020

Conversation

gerritholl
Copy link
Collaborator

When linking to jupyter notebooks from the Satpy documentation, add a
direct link to nbviewer rather than to Github. Github often fails to
render notebooks.

  • Fully documented

When linking to jupyter notebooks from the Satpy documentation, add a
direct link to nbviewer rather than to Github.  Github often fails to
render notebooks.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 90.136% when pulling 02cd737 on gerritholl:use-nbviewer into b0d8460 on pytroll:master.

@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #1325 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1325   +/-   ##
=======================================
  Coverage   90.13%   90.13%           
=======================================
  Files         220      220           
  Lines       32512    32512           
=======================================
  Hits        29305    29305           
  Misses       3207     3207           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0d8460...02cd737. Read the comment docs.

@mraspaud
Copy link
Member

Did you check that they all render correctly in nbviewer? Iirc I had cases where Github would render better than nbviewer, depending on where the images we're hosted

@gerritholl
Copy link
Collaborator Author

No, I didn't check if they all render correctly in nbviewer. Considering that none of them render anything in Github at all, any rendering is better than none.

@mraspaud
Copy link
Member

We've discussed the possibility of a generated gallery indeed, but haven't found a solution yet

@gerritholl
Copy link
Collaborator Author

Until we have that, I think viewing the notebooks with most images missing (such as this PR) is still an improvement to not being able to view them at all (in my experience, Github viewing of notebooks almost never works).

@mraspaud mraspaud merged commit 6f3e9e3 into pytroll:master Sep 9, 2020
@mraspaud mraspaud added this to the v0.23.0 milestone Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants