Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to datasetid in tests.utils. #1332

Merged
merged 1 commit into from Sep 1, 2020

Conversation

gerritholl
Copy link
Collaborator

Remove reference to DatasetID in tests.utils.make_a_fake_scene documentation.

  • Passes flake8 satpy
  • Fully documented

Remove reference to DatasetID in tests.utils.make_a_fake_scene
documentation.
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this too and included it in my #1327

@gerritholl
Copy link
Collaborator Author

I noticed this too and included it in my #1327

Oh, I didn't notice that one before. Shall I close this one?

@djhoese
Copy link
Member

djhoese commented Sep 1, 2020

Eh might be nice to have another committer. Let's leave it and merge this.

@gerritholl
Copy link
Collaborator Author

I thought small PRs were preferred ;)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.241% when pulling 2ecd435 on gerritholl:remove-datasetid-reference into 280d863 on pytroll:master.

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #1332 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1332   +/-   ##
=======================================
  Coverage   90.24%   90.24%           
=======================================
  Files         222      222           
  Lines       32719    32719           
=======================================
  Hits        29526    29526           
  Misses       3193     3193           
Impacted Files Coverage Δ
satpy/tests/utils.py 95.40% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 280d863...2ecd435. Read the comment docs.

@mraspaud mraspaud merged commit e77cd29 into pytroll:master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants