Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update seviri icare tests #1342

Merged
merged 3 commits into from Sep 9, 2020
Merged

Update seviri icare tests #1342

merged 3 commits into from Sep 9, 2020

Conversation

simonrp84
Copy link
Member

@simonrp84 simonrp84 commented Sep 4, 2020

The seviri icare reader had poor test coverage, and quite a few things weren't being tested at all.

This PR updates the tests to fix the above, and now tests everything of importance.

  • Tests added
  • Passes flake8 satpy
  • Fully documented

@coveralls
Copy link

coveralls commented Sep 4, 2020

Coverage Status

Coverage increased (+0.2%) to 90.393% when pulling 30af77a on simonrp84:icare_tests into e77cd29 on pytroll:master.

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #1342 into master will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1342      +/-   ##
==========================================
+ Coverage   90.24%   90.39%   +0.15%     
==========================================
  Files         222      228       +6     
  Lines       32719    33017     +298     
==========================================
+ Hits        29526    29845     +319     
+ Misses       3193     3172      -21     
Impacted Files Coverage Δ
satpy/tests/reader_tests/test_seviri_l1b_icare.py 100.00% <100.00%> (+1.04%) ⬆️
satpy/tests/reader_tests/test_netcdf_utils.py 94.79% <0.00%> (-0.82%) ⬇️
satpy/composites/__init__.py 82.76% <0.00%> (-0.17%) ⬇️
satpy/readers/yaml_reader.py 95.07% <0.00%> (-0.17%) ⬇️
satpy/scene.py 90.42% <0.00%> (-0.16%) ⬇️
satpy/dependency_tree.py 97.26% <0.00%> (-0.01%) ⬇️
satpy/tests/test_yaml_reader.py 99.83% <0.00%> (-0.01%) ⬇️
satpy/tests/utils.py 95.40% <0.00%> (ø)
satpy/writers/cf_writer.py 93.77% <0.00%> (ø)
satpy/tests/test_dataset.py 100.00% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e77cd29...30af77a. Read the comment docs.

@simonrp84 simonrp84 closed this Sep 4, 2020
@simonrp84 simonrp84 reopened this Sep 4, 2020
@mraspaud mraspaud added cleanup Code cleanup but otherwise no change in functionality enhancement code enhancements, features, improvements component:readers labels Sep 7, 2020
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on adding the area and other attribute checks. Just some readability issues I'd like to clarify.

satpy/tests/reader_tests/test_seviri_l1b_icare.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_seviri_l1b_icare.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_seviri_l1b_icare.py Outdated Show resolved Hide resolved
@simonrp84 simonrp84 added this to the v0.23.0 milestone Sep 9, 2020
@mraspaud mraspaud merged commit f933546 into pytroll:master Sep 9, 2020
@simonrp84 simonrp84 deleted the icare_tests branch September 9, 2020 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Code cleanup but otherwise no change in functionality component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants