Reintroduce support for pyproj 1.9.6 in cf_writer #1352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The create_grid_mapping need a newer version of pyproj, by moving the import to that function data with lat/lon can still be written.
|
👉 View analysis in DeepCode’s Dashboard | Configure the bot |
|
@ninahakansson I suppose you mean Edit: fixed the title to replace |
mraspaud
added
component:writers
enhancement
mraspaud
changed the title
|
Retry DeepCode |
djhoese
approved these changes
Sep 8, 2020
mraspaud
approved these changes
Sep 8, 2020
|
Tests are coming |
Codecov Report
@@ Coverage Diff @@
## master #1352 +/- ##
==========================================
+ Coverage 90.26% 90.28% +0.01%
==========================================
Files 226 226
Lines 32718 32721 +3
==========================================
+ Hits 29534 29542 +8
+ Misses 3184 3179 -5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The create_grid_mapping in cf_writer need a newer version of pyproj.
By moving the import of pyproj to that function data with lat/lon can still be written also with pyproj==1.9.6.
flake8 satpy