Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update name for gridded AHI reader #1354

Merged
merged 3 commits into from Sep 13, 2020
Merged

Update name for gridded AHI reader #1354

merged 3 commits into from Sep 13, 2020

Conversation

simonrp84
Copy link
Member

The AHI gridded PR used an incorrect reader name (ahi_gridded). This PR updates the name to ahi_l1b_gridded_bin.

@coveralls
Copy link

coveralls commented Sep 9, 2020

Coverage Status

Coverage increased (+0.1%) to 90.466% when pulling e4ec986 on simonrp84:gridded_ahi_reader into 4b5c503 on pytroll:master.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #1354 into master will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1354      +/-   ##
==========================================
+ Coverage   90.35%   90.46%   +0.11%     
==========================================
  Files         228      228              
  Lines       32993    33217     +224     
==========================================
+ Hits        29811    30050     +239     
+ Misses       3182     3167      -15     
Impacted Files Coverage Δ
satpy/readers/ahi_l1b_gridded_bin.py 99.05% <ø> (ø)
...tpy/tests/reader_tests/test_ahi_l1b_gridded_bin.py 99.34% <100.00%> (ø)
satpy/scene.py 90.42% <0.00%> (-0.18%) ⬇️
satpy/readers/seviri_l1b_nc.py 43.10% <0.00%> (ø)
satpy/readers/seviri_l1b_hrit.py 92.18% <0.00%> (ø)
satpy/readers/seviri_l1b_native.py 73.94% <0.00%> (ø)
satpy/tests/reader_tests/test_utils.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_aapp_l1b.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_seviri_base.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_vaisala_gld360.py 100.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b5c503...e4ec986. Read the comment docs.

@simonrp84 simonrp84 added this to the v0.23.0 milestone Sep 10, 2020
@zxdawn
Copy link
Member

zxdawn commented Sep 11, 2020

I suppose it's better to show the data origin (Chiba University) in the name. Otherwise, it will be confused with the official one.

@mraspaud
Copy link
Member

@simonrp84 could you add the source as @zxdawn suggests in the reader table?

@simonrp84
Copy link
Member Author

@mraspaud By 'reader table' do you mean doc/source/index.rst? If so, I'll add it there. Otherwise let me know which doc :)

@djhoese
Copy link
Member

djhoese commented Sep 11, 2020

Yes that file. The table is at the bottom.

@simonrp84
Copy link
Member Author

Ok, I've done this now!

@mraspaud mraspaud merged commit 5b45c32 into pytroll:master Sep 13, 2020
@simonrp84 simonrp84 deleted the gridded_ahi_reader branch September 13, 2020 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants