New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update name for gridded AHI reader #1354
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## master #1354 +/- ##
==========================================
+ Coverage 90.35% 90.46% +0.11%
==========================================
Files 228 228
Lines 32993 33217 +224
==========================================
+ Hits 29811 30050 +239
+ Misses 3182 3167 -15
Continue to review full report at Codecov.
|
I suppose it's better to show the data origin (Chiba University) in the name. Otherwise, it will be confused with the official one. |
@simonrp84 could you add the source as @zxdawn suggests in the reader table? |
@mraspaud By 'reader table' do you mean |
Yes that file. The table is at the bottom. |
Ok, I've done this now! |
The AHI gridded PR used an incorrect reader name (
ahi_gridded
). This PR updates the name toahi_l1b_gridded_bin
.