Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong number of scanlines in eps reader #1368

Merged
merged 8 commits into from Sep 17, 2020

Conversation

mraspaud
Copy link
Member

Sometimes the number of declared scanlines in the eps l1b files is different from the number of MDR records. This PR ensures we use the number of records as truth.

@TalfanBarnie Can you test if this works for you?

@coveralls
Copy link

coveralls commented Sep 16, 2020

Coverage Status

Coverage increased (+0.05%) to 90.517% when pulling 1571c9d on mraspaud:fix_eps_number_of_scanlines into d728506 on pytroll:master.

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #1368 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1368      +/-   ##
==========================================
+ Coverage   90.46%   90.52%   +0.05%     
==========================================
  Files         228      228              
  Lines       33217    33334     +117     
==========================================
+ Hits        30050    30174     +124     
+ Misses       3167     3160       -7     
Impacted Files Coverage Δ
satpy/readers/eps_l1b.py 76.13% <100.00%> (+2.25%) ⬆️
satpy/tests/reader_tests/test_eps_l1b.py 100.00% <100.00%> (ø)
satpy/tests/writer_tests/test_cf.py 99.64% <0.00%> (+0.02%) ⬆️
satpy/scene.py 90.59% <0.00%> (+0.17%) ⬆️
satpy/writers/cf_writer.py 94.09% <0.00%> (+0.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d728506...1571c9d. Read the comment docs.

@mraspaud
Copy link
Member Author

Confirmed to work from @TalfanBarnie who reported #1367

Copy link
Member

@pnuu pnuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Few suggestions and one question inline.

satpy/tests/reader_tests/test_eps_l1b.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_eps_l1b.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_eps_l1b.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_eps_l1b.py Outdated Show resolved Hide resolved
satpy/readers/eps_l1b.py Outdated Show resolved Hide resolved
@mraspaud mraspaud merged commit aa65035 into pytroll:master Sep 17, 2020
@mraspaud mraspaud deleted the fix_eps_number_of_scanlines branch September 17, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AVHRR lat/lon grids incorrect size
3 participants