New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wrong number of scanlines in eps reader #1368
Fix wrong number of scanlines in eps reader #1368
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1368 +/- ##
==========================================
+ Coverage 90.46% 90.52% +0.05%
==========================================
Files 228 228
Lines 33217 33334 +117
==========================================
+ Hits 30050 30174 +124
+ Misses 3167 3160 -7
Continue to review full report at Codecov.
|
Confirmed to work from @TalfanBarnie who reported #1367 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Few suggestions and one question inline.
Sometimes the number of declared scanlines in the eps l1b files is different from the number of MDR records. This PR ensures we use the number of records as truth.
flake8 satpy
@TalfanBarnie Can you test if this works for you?