Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug getting name to the calibration in mitiff writer #1382

Merged

Conversation

TAlonglong
Copy link
Collaborator

@TAlonglong TAlonglong commented Sep 24, 2020

Fixed bug getting name from the prerequisites when the prereq consist of DataQuery objects

  • Tests added
  • Passes flake8 satpy

…creation of set inside some sensor in the test
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 90.518% when pulling 947c6d3 on TAlonglong:bug-mitiff-writer-name-paramater into 1612d84 on pytroll:master.

@coveralls
Copy link

coveralls commented Sep 24, 2020

Coverage Status

Coverage increased (+0.007%) to 90.533% when pulling 947c6d3 on TAlonglong:bug-mitiff-writer-name-paramater into 1612d84 on pytroll:master.

@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #1382 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1382   +/-   ##
=======================================
  Coverage   90.52%   90.53%           
=======================================
  Files         228      228           
  Lines       33377    33401   +24     
=======================================
+ Hits        30215    30239   +24     
  Misses       3162     3162           
Impacted Files Coverage Δ
satpy/tests/writer_tests/test_mitiff.py 99.16% <100.00%> (+0.05%) ⬆️
satpy/writers/mitiff.py 91.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1612d84...947c6d3. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice with the real testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants