Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Near-realtime VIIRS L1b data. #1420

Merged
merged 1 commit into from Nov 2, 2020
Merged

Add support for Near-realtime VIIRS L1b data. #1420

merged 1 commit into from Nov 2, 2020

Conversation

simonrp84
Copy link
Member

Currently, the viirs_l1b reader only supports archived VIIRS data from NASA. This PR adds support for the near realtime data, which has a slightly different filename structure.

@codecov
Copy link

codecov bot commented Oct 31, 2020

Codecov Report

Merging #1420 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1420   +/-   ##
=======================================
  Coverage   90.58%   90.58%           
=======================================
  Files         236      236           
  Lines       33797    33797           
=======================================
  Hits        30615    30615           
  Misses       3182     3182           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d5bfdb...b91cc4e. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 90.585% when pulling b91cc4e on simonrp84:viirs_l1b+nrt into 2d5bfdb on pytroll:master.

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with this, but wondering if it could be more generic? Any idea if anyone uses something besides _NRT? Maybe a wildcard {processing_suffix} would be good? I know @mraspaud didn't like the idea of this for the ABI reader in a recent PR I made or at least not as an all-in-one file pattern.

Eh on second though maybe it is better to be explicit.

@djhoese
Copy link
Member

djhoese commented Oct 31, 2020

Where does the NRT data come from? Is there a URL we could/should add to a docstring somewhere?

@simonrp84
Copy link
Member Author

The NRT data comes from the same source as the 'normal' data that's already supported by this reader, they're both NASA products and are available from the same places (earthdata, f.ex).

@djhoese djhoese self-assigned this Nov 2, 2020
@djhoese djhoese added component:readers enhancement code enhancements, features, improvements labels Nov 2, 2020
@djhoese djhoese merged commit 9ccddbf into pytroll:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants