Add reader for FIDUCEO MVIRI FCDR data

[sfinkens]

Add a reader for FIDUCEO MVIRI FCDR data in netCDF format. Both full and easy FCDR are supported.

---

Example usage:

from satpy import Scene

scn = Scene(filenames=['FIDUCEO_FCDR_L15_MVIRI_MET7-57.0...'],
            reader='mviri_l1b_fiduceo_nc',
            reader_kwargs={'mask_bad_quality': False})
scn.load(['VIS', 'WV', 'IR'], upper_right_corner='NE')

---

Example images (with upper_right_corner='native'):

---

Difference between lon/lat from area definition and "static FCDR"

• Tests added
• Passes flake8 satpy
• Fully documented

[ghost]

Congratulations 🎉. DeepCode analyzed your code in 3.078 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

[codecov]

Codecov Report

Merging #1427 (c5b5331) into master (2d5bfdb) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1427      +/-   ##
==========================================
+ Coverage   90.58%   90.63%   +0.05%     
==========================================
  Files         236      240       +4     
  Lines       33797    34582     +785     
==========================================
+ Hits        30615    31345     +730     
- Misses       3182     3237      +55     

Flag	Coverage Δ
behaviourtests	4.47% <0.00%> (?)
unittests	91.11% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
satpy/readers/_geos_area.py	100.00% <100.00%> (ø)
satpy/readers/mviri_l1b_fiduceo_nc.py	100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_geos_area.py	100.00% <100.00%> (ø)
...py/tests/reader_tests/test_mviri_l1b_fiduceo_nc.py	100.00% <100.00%> (ø)
satpy/utils.py	24.09% <0.00%> (-46.39%)	⬇️
satpy/readers/nwcsaf_msg2013_hdf5.py	94.87% <0.00%> (-1.29%)	⬇️
satpy/resample.py	89.69% <0.00%> (-1.09%)	⬇️
satpy/readers/hdf5_utils.py	91.42% <0.00%> (-1.00%)	⬇️
satpy/readers/viirs_sdr.py	85.63% <0.00%> (-0.21%)	⬇️
satpy/tests/test_yaml_reader.py	99.83% <0.00%> (ø)
... and 26 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d5bfdb...c5b5331. Read the comment docs.

[coveralls]

Coverage decreased (-0.3%) to 90.237% when pulling 0b6e49d on sfinkens:feature-fiduceo-mviri into 979608a on pytroll:master.

[simonrp84]

Do the example images correspond to the example code?
I ask because you have upper_right_corner='NE' in the code but this is clearly not the case for the images!
Just want to check in case there's an issue there, unfortunately I don't have any data to test with :)

[simonrp84]

LGTM, can't see anything wrong or in need of improvement in there!

[sfinkens]

Do the example images correspond to the example code?

@simonrp84 You're right, this is a bit confusing. The sample images were created with upper_right_corner='native' .

[mraspaud]

Looks good! I some comments, but please write the tests before addressing them 👍

Also, don't forget to add the reader to the table in the index.rst file.

[mraspaud]

I still have a couple of comments. Also, how is it with sun-earth distance in these data?

[mraspaud]

Also could you try to address the codebeat and deepcode issues?

[sfinkens]

I'll try :)

Also could you try to address the codebeat and deepcode issues?

[mraspaud]

Do. Or do not. There is no try.

;)

[sfinkens]

Retry DeepCode

[mraspaud]

@sfinkens looks really good now! Almost there, just three lines that miss coverage!