Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of modifiers in satpy-cf reader #1447

Merged
merged 1 commit into from Nov 23, 2020

Conversation

sfinkens
Copy link
Member

@sfinkens sfinkens commented Nov 23, 2020

Coordinates can have a modifiers attribute, too.

  • Tests added
  • Passes flake8 satpy

@codecov
Copy link

codecov bot commented Nov 23, 2020

Codecov Report

Merging #1447 (1ce23a5) into master (bfc7bfb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1447   +/-   ##
=======================================
  Coverage   90.52%   90.52%           
=======================================
  Files         238      238           
  Lines       34152    34153    +1     
=======================================
+ Hits        30915    30916    +1     
  Misses       3237     3237           
Flag Coverage Δ
behaviourtests 4.52% <0.00%> (-0.01%) ⬇️
unittests 91.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/tests/reader_tests/test_satpy_cf_nc.py 100.00% <ø> (ø)
satpy/readers/satpy_cf_nc.py 98.57% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfc7bfb...1ce23a5. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants