Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to FCI reader to include CT, CTTH, GII and the latest filenam… #1465

Merged
merged 13 commits into from Dec 17, 2020

Conversation

ColinDuff
Copy link
Contributor

Draft PR for the updates need for the FCI L2 PF to read the CT, CTTH, GII products and to use the latest product filename format

ASR to follow

@codecov
Copy link

codecov bot commented Dec 2, 2020

Codecov Report

Merging #1465 (104db01) into master (a18b6e2) will increase coverage by 1.08%.
The diff coverage is 99.46%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1465      +/-   ##
==========================================
+ Coverage   90.52%   91.60%   +1.08%     
==========================================
  Files         238      246       +8     
  Lines       34153    35964    +1811     
==========================================
+ Hits        30916    32944    +2028     
+ Misses       3237     3020     -217     
Flag Coverage Δ
behaviourtests 4.38% <0.00%> (-0.15%) ⬇️
unittests 92.07% <99.46%> (+1.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/fci_l2_nc.py 92.80% <98.27%> (+13.90%) ⬆️
satpy/tests/reader_tests/test_fci_l2_nc.py 100.00% <100.00%> (+4.70%) ⬆️
satpy/readers/seviri_l1b_hrit.py 90.93% <0.00%> (-1.25%) ⬇️
satpy/readers/_geos_area.py 100.00% <0.00%> (ø)
satpy/tests/test_file_handlers.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_glm_l2.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_abi_l1b.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_olci_nc.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_eum_base.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_geos_area.py 100.00% <0.00%> (ø)
... and 41 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a18b6e2...104db01. Read the comment docs.

satpy/readers/fci_l2_nc.py Outdated Show resolved Hide resolved
@ameraner ameraner added this to In Progress in PCW Autumn 2020 Dec 4, 2020
@ghost
Copy link

ghost commented Dec 4, 2020

DeepCode's analysis on #104db0 found:

  • ℹ️ 2 minor issues. 👇
  • ✔️ 1 issue was fixed.

Top issues

Description Example fixes
Access to a protected member _start_time of a client class Occurrences: 🔧 Example fixes
Imports from package unittest are not grouped Occurrences: 🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@ColinDuff
Copy link
Contributor Author

For the ASR data, it will return a 4 dimensional area for the product parameters.

So eg scn.show('bt_mean') would not work , the user would have to do
data=scn['bt_mean'].values[:,:,1,1]
to visualise the data.
The returned xarray dataset has the dimensions marked accordingly so the user knows what the correspond to

satpy/readers/fci_l2_nc.py Outdated Show resolved Hide resolved
@ColinDuff ColinDuff marked this pull request as ready for review December 10, 2020 14:27
@mraspaud mraspaud added component:readers enhancement code enhancements, features, improvements labels Dec 16, 2020
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this PR, just a few suggestions and comments. Thanks for adding aaaaaaaall the new datasets!!!

satpy/tests/reader_tests/test_fci_l2_nc.py Outdated Show resolved Hide resolved
satpy/readers/fci_l2_nc.py Outdated Show resolved Hide resolved
satpy/readers/fci_l2_nc.py Outdated Show resolved Hide resolved
satpy/readers/fci_l2_nc.py Outdated Show resolved Hide resolved
satpy/tests/reader_tests/test_fci_l2_nc.py Outdated Show resolved Hide resolved
satpy/readers/fci_l2_nc.py Show resolved Hide resolved
satpy/readers/fci_l2_nc.py Show resolved Hide resolved
@mraspaud mraspaud merged commit d7e2570 into pytroll:master Dec 17, 2020
PCW Autumn 2020 automation moved this from In Progress to Done Dec 17, 2020
@ColinDuff ColinDuff deleted the fci_readers_development branch December 17, 2020 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants