New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix wavelength range print out to use regular nbsp #1466
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1466 +/- ##
=======================================
Coverage 90.58% 90.58%
=======================================
Files 239 239
Lines 34313 34313
=======================================
Hits 31081 31081
Misses 3232 3232
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What does @gerritholl have to say about this? Wasn't there some ISO specification for non-breaking spaces and units? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot!
@sfinkens did you get to test it in your sensitive terminal? |
Yes it works fine! |
I thought this was in ISO 80000-1, but apparently not. §7.1.4 states:
Then there is §7.2.2 about compound units, which states that a compound unit may be written as "N · m", "N m", or "Nm". The latter alternative is not permitted if the first unit is either metre or Tesla as those can be confused with prefixes milli and tera, respectively. The ISO standard doesn't specify what type of space shall be placed between the value and the symbol. Since we're only handling wavelengths here and not angles, the display was fine with ISO 80000-1 before this PR and remains fine with ISO 80000-1 after this PR. |
The International System of Units page on wikipedia says:
(https://en.wikipedia.org/wiki/International_System_of_Units#General_rules)
so a regular (not narrow) space is now used when displaying wavelength ranges.