Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove x/y coordinates in mviri_l1b_fiduceo_nc #1481

Merged
merged 1 commit into from Dec 10, 2020

Conversation

sfinkens
Copy link
Member

@sfinkens sfinkens commented Dec 9, 2020

Remove x/y coordinates from mviri_l1b_fiduceo_nc datasets as they only contain image rows/columns and prevent satpy from adding projection coordinates (based on the area definition).

  • Tests added
  • Passes flake8 satpy

@codecov
Copy link

codecov bot commented Dec 9, 2020

Codecov Report

Merging #1481 (636eb43) into master (9101690) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1481   +/-   ##
=======================================
  Coverage   90.70%   90.70%           
=======================================
  Files         241      241           
  Lines       34758    34761    +3     
=======================================
+ Hits        31526    31529    +3     
  Misses       3232     3232           
Flag Coverage Δ
behaviourtests 4.47% <0.00%> (-0.01%) ⬇️
unittests 91.17% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...py/tests/reader_tests/test_mviri_l1b_fiduceo_nc.py 100.00% <ø> (ø)
satpy/readers/mviri_l1b_fiduceo_nc.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9101690...636eb43. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mraspaud mraspaud merged commit a3774e1 into pytroll:master Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants