New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with reading MSG GRIB products from the eumetsat datastore #1503
Fix issue with reading MSG GRIB products from the eumetsat datastore #1503
Conversation
…etsat datastore and added AES, CTH, MPE and ClearSkyMap GRIB products
Congratulations 🎉. DeepCode analyzed your code in 3.295 seconds and we found no issues. Enjoy a moment of no bugs ☀️. 👉 View analysis in DeepCode’s Dashboard | Configure the bot |
Codecov Report
@@ Coverage Diff @@
## master #1503 +/- ##
=======================================
Coverage 91.62% 91.62%
=======================================
Files 246 246
Lines 36019 36008 -11
=======================================
- Hits 33001 32993 -8
+ Misses 3018 3015 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments inline otherwise it looks pretty good. If there are a lot of fields in these files it may be time to try to replace the long set of yaml datasets with the available_datasets
method in the reader to dynamically determine what's available from the files provided.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…etsat datastore and added AES, CTH, MPE and ClearSkyMap GRIB products
Resolves Issue 1477 by adding the EUMETSAT Datastore file pattern
Also further Seviri Grib products were added
A line of code in the reader was also fixed as it didnt seem to be working correctly
Closes #1477
Test script ran and no problems were observed
Passes
flake8 satpy