Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with reading MSG GRIB products from the eumetsat datastore #1503

Merged
merged 4 commits into from Jan 22, 2021

Conversation

ColinDuff
Copy link
Contributor

…etsat datastore and added AES, CTH, MPE and ClearSkyMap GRIB products

Resolves Issue 1477 by adding the EUMETSAT Datastore file pattern

Also further Seviri Grib products were added

A line of code in the reader was also fixed as it didnt seem to be working correctly

Closes #1477
Test script ran and no problems were observed
Passes flake8 satpy

…etsat datastore and added AES, CTH, MPE and ClearSkyMap GRIB products
@ghost
Copy link

ghost commented Jan 5, 2021

Congratulations 🎉. DeepCode analyzed your code in 3.295 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@codecov
Copy link

codecov bot commented Jan 5, 2021

Codecov Report

Merging #1503 (3ea7001) into master (33c3c8d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1503   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         246      246           
  Lines       36019    36008   -11     
=======================================
- Hits        33001    32993    -8     
+ Misses       3018     3015    -3     
Flag Coverage Δ
behaviourtests 4.38% <0.00%> (-0.04%) ⬇️
unittests 92.17% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/seviri_l2_grib.py 86.73% <100.00%> (ø)
satpy/utils.py 23.41% <0.00%> (-0.69%) ⬇️
satpy/composites/config_loader.py 84.61% <0.00%> (-0.25%) ⬇️
satpy/readers/__init__.py 97.40% <0.00%> (-0.06%) ⬇️
satpy/readers/agri_l1.py 99.15% <0.00%> (-0.03%) ⬇️
satpy/tests/test_scene.py 99.72% <0.00%> (-0.01%) ⬇️
satpy/plugin_base.py 88.00% <0.00%> (ø)
satpy/readers/eps_l1b.py 76.22% <0.00%> (ø)
satpy/composites/viirs.py 83.89% <0.00%> (ø)
satpy/tests/test_utils.py 100.00% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33c3c8d...3ea7001. Read the comment docs.

@ColinDuff ColinDuff marked this pull request as ready for review January 7, 2021 10:46
@ColinDuff
Copy link
Contributor Author

@mraspaud @djhoese
can you have a look at this PR - mainly yaml file updates
does it look ok to you

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments inline otherwise it looks pretty good. If there are a lot of fields in these files it may be time to try to replace the long set of yaml datasets with the available_datasets method in the reader to dynamically determine what's available from the files provided.

satpy/readers/seviri_l2_grib.py Outdated Show resolved Hide resolved
satpy/etc/readers/seviri_l2_grib.yaml Outdated Show resolved Hide resolved
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. LGTM

@djhoese djhoese changed the title Code updated to fix issue with reading MSG GRIB products from the eum… Fix issue with reading MSG GRIB products from the eumetsat datastore Jan 20, 2021
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 2df64af into pytroll:master Jan 22, 2021
@ColinDuff ColinDuff deleted the seviri_l2_grib_reader_update branch January 22, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seviri l2 grib add file names from Eumetsat datastore
3 participants