Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass pathlike-objects to FSFile #1519

Merged
merged 2 commits into from Jan 29, 2021

Conversation

gerritholl
Copy link
Collaborator

When constructing an FSFile object, allow to pass not only strings, but
any object meeting the os.PathLike protocol.

When constructing an FSFile object, allow to pass not only strings, but
any object meeting the os.PathLike protocol.
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #1519 (3dcf240) into master (653afc0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1519   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         248      248           
  Lines       36167    36172    +5     
=======================================
+ Hits        33150    33155    +5     
  Misses       3017     3017           
Flag Coverage Δ
behaviourtests 4.35% <0.00%> (-0.01%) ⬇️
unittests 92.19% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/__init__.py 97.40% <100.00%> (ø)
satpy/tests/test_readers.py 99.20% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 653afc0...3dcf240. Read the comment docs.

@gerritholl
Copy link
Collaborator Author

As often, the codecov report makes no sense. I've only added test code and test coverage has gone down?

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it. One small docstring change please.

satpy/readers/__init__.py Outdated Show resolved Hide resolved
Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this functionality

@mraspaud mraspaud merged commit e0f1fb8 into pytroll:master Jan 29, 2021
@gerritholl gerritholl deleted the fsfile-fspath branch January 29, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FSFile should support any PathLike objects
3 participants