New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to pass pathlike-objects to FSFile #1519
Conversation
When constructing an FSFile object, allow to pass not only strings, but any object meeting the os.PathLike protocol.
Codecov Report
@@ Coverage Diff @@
## master #1519 +/- ##
=======================================
Coverage 91.65% 91.65%
=======================================
Files 248 248
Lines 36167 36172 +5
=======================================
+ Hits 33150 33155 +5
Misses 3017 3017
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
As often, the codecov report makes no sense. I've only added test code and test coverage has gone down? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing it. One small docstring change please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adding this functionality
When constructing an FSFile object, allow to pass not only strings, but
any object meeting the os.PathLike protocol.
flake8 satpy