Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When saving to CF prepend datasets starting with a digit by CHANNEL_ #1525
When saving to CF prepend datasets starting with a digit by CHANNEL_ #1525
Changes from 2 commits
5af9f73
bda9f1c
9bc7821
c537672
1c1898a
9d55746
9dc8d27
02a3ce2
8de0bb9
a0d916c
7e8b651
c0859bd
c346926
eb25edd
3783dc7
563b974
8113a47
d795043
680cef6
b9aeadf
3a01818
436ac0c
a38f08f
5604246
152c123
b11317c
ae54ba6
57d5fea
7dec6fb
e5b8c17
db34a63
5a39dbc
88d8320
0351ba4
19f9397
6d66cf9
4b4fcd1
ebdce35
0042192
8eaeedd
3e9d293
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about renaming this keyword argument
numeric_name_prefix
and if it is None, don't do anything. If it is specified then it is assumed to be a string. So someone could doscn.save_datasets(writer='cf', numeric_name_prefix='ch')
if they wanted to?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds like a good idea.
I just have not figured out how to read this back if we are to skip the extra attribute I have added for now.