Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SLSTR composites for oblique view #1533

Merged
merged 1 commit into from Feb 3, 2021

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Feb 3, 2021

This makes the view id key transitive for composites too.

@mraspaud mraspaud self-assigned this Feb 3, 2021
@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #1533 (982bb06) into master (e0f1fb8) will decrease coverage by 1.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1533      +/-   ##
==========================================
- Coverage   91.65%   90.51%   -1.15%     
==========================================
  Files         248      248              
  Lines       36172    36172              
==========================================
- Hits        33155    32740     -415     
- Misses       3017     3432     +415     
Flag Coverage Δ
behaviourtests 4.35% <ø> (ø)
unittests 91.03% <ø> (-1.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/tests/reader_tests/test_seviri_l2_grib.py 23.07% <0.00%> (-76.93%) ⬇️
satpy/tests/reader_tests/test_seviri_l2_bufr.py 30.35% <0.00%> (-69.65%) ⬇️
satpy/readers/iasi_l2_so2_bufr.py 25.80% <0.00%> (-68.82%) ⬇️
satpy/readers/ascat_l2_soilmoisture_bufr.py 29.87% <0.00%> (-67.54%) ⬇️
satpy/tests/reader_tests/test_iasi_l2_so2_bufr.py 30.98% <0.00%> (-66.20%) ⬇️
...ts/reader_tests/test_ascat_l2_soilmoisture_bufr.py 37.20% <0.00%> (-60.47%) ⬇️
satpy/readers/seviri_l2_grib.py 26.53% <0.00%> (-60.21%) ⬇️
satpy/readers/seviri_l2_bufr.py 34.52% <0.00%> (-59.53%) ⬇️
satpy/writers/cf_writer.py 93.57% <0.00%> (-0.31%) ⬇️
satpy/scene.py 92.07% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f1fb8...15602f7. Read the comment docs.

@mraspaud mraspaud marked this pull request as ready for review February 3, 2021 21:56
@mraspaud mraspaud merged commit c3fcca8 into pytroll:master Feb 3, 2021
@mraspaud mraspaud deleted the fix-slstr-composites branch February 3, 2021 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading SLSTR composite doesn't respect the view
2 participants