Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static scale_factor/add_offset/_FillValue to awips_tiled GLM config #1537

Merged
merged 1 commit into from Feb 9, 2021

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 7, 2021

This is purely a configuration change to the configuration file used by the awips_tiled writer. This change is specific to the GLM "Full Disk" file scheme used by AWIPS and only effects the "Flash_extent_density" variable. The reason for this change is an apparent bug in AWIPS where for only the FED variable, the scale_factor/add_offset/_FillValue are ignored. In the best case we would use a scale_factor of 1.0 and add_offset of 0.0, but AWIPS, for some reason, does not allow "identity" scalings so 1.0 is not allowed. The change in this PR makes the scale_factor as close to 1.0 as possible for a 32-bit float so that the values in the file should nearly represent the original values.

The AWIPS bug is still being investigated, but in the mean time this workaround should be backwards compatible and allow us to continue our work.

@codecov
Copy link

codecov bot commented Feb 7, 2021

Codecov Report

Merging #1537 (01e0908) into master (e0f1fb8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1537   +/-   ##
=======================================
  Coverage   91.65%   91.65%           
=======================================
  Files         248      248           
  Lines       36172    36172           
=======================================
  Hits        33155    33155           
  Misses       3017     3017           
Flag Coverage Δ
behaviourtests 4.35% <ø> (ø)
unittests 92.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0f1fb8...01e0908. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djhoese djhoese merged commit 6e4d583 into pytroll:master Feb 9, 2021
@djhoese djhoese deleted the bugfix-awips-glm-fed branch February 9, 2021 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants