Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'environment_prefix' to AWIPS tiled writer for flexible filenames #1548

Merged
merged 2 commits into from Feb 18, 2021

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 17, 2021

Different processing environments may want different prefixes for files that will go to AWIPS. This is semi-standard for AWIPS tiled files (OR, OT, etc). This PR adds a new environment_prefix kwarg to the writer to control this for the GLM templates and fixes an issue where tile_number wasn't being provided to the user provided custom filename format string.

  • Tests added
  • Fully documented

CC @rayg-ssec @nbearson

@djhoese
Copy link
Member Author

djhoese commented Feb 17, 2021

Closes #894

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #1548 (461fc94) into master (b792f29) will increase coverage by 0.08%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1548      +/-   ##
==========================================
+ Coverage   92.09%   92.17%   +0.08%     
==========================================
  Files         251      251              
  Lines       36711    36749      +38     
==========================================
+ Hits        33808    33874      +66     
+ Misses       2903     2875      -28     
Flag Coverage Δ
behaviourtests 4.48% <0.00%> (-0.01%) ⬇️
unittests 92.71% <96.77%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/tests/writer_tests/test_awips_tiled.py 98.24% <95.45%> (-0.25%) ⬇️
satpy/writers/awips_tiled.py 82.96% <100.00%> (+0.21%) ⬆️
satpy/readers/file_handlers.py 95.77% <0.00%> (-1.41%) ⬇️
satpy/tests/reader_tests/test_viirs_compact.py 100.00% <0.00%> (ø)
satpy/readers/viirs_compact.py 76.04% <0.00%> (+11.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b792f29...461fc94. Read the comment docs.

@ghost
Copy link

ghost commented Feb 18, 2021

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

@djhoese
Copy link
Member Author

djhoese commented Feb 18, 2021

Tests pass. Coverage went up. Codebeat is confused. Merging.

@djhoese djhoese merged commit 3544d60 into pytroll:master Feb 18, 2021
@djhoese djhoese deleted the bugfix-awips-tiled-env-prefix branch February 18, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant