Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow 'glm_l2' reader to accept arbitrary filename prefixes #1563

Merged
merged 3 commits into from Feb 23, 2021

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 23, 2021

Plans are coming down the pipe that will make it more common for arbitrary filename prefixes in PUG-like files. Specifically the CSPP Geo Gridded GLM package will default to a CSPP_CG prefix instead of the operational realtime prefix OR.

  • Tests added

@djhoese djhoese added enhancement code enhancements, features, improvements component:readers labels Feb 23, 2021
@djhoese djhoese self-assigned this Feb 23, 2021
@ghost
Copy link

ghost commented Feb 23, 2021

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #1563 (8bf3ef8) into master (21ebf26) will increase coverage by 0.33%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1563      +/-   ##
==========================================
+ Coverage   92.21%   92.54%   +0.33%     
==========================================
  Files         251      251              
  Lines       36761    36761              
==========================================
+ Hits        33900    34022     +122     
+ Misses       2861     2739     -122     
Flag Coverage Δ
behaviourtests 4.49% <0.00%> (ø)
unittests 92.68% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/tests/reader_tests/test_glm_l2.py 100.00% <100.00%> (ø)
satpy/readers/glm_l2.py 98.55% <0.00%> (+2.89%) ⬆️
satpy/utils.py 81.95% <0.00%> (+58.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21ebf26...a39597a. Read the comment docs.

@djhoese djhoese merged commit d556c80 into pytroll:master Feb 23, 2021
@djhoese djhoese deleted the feature-glm-l2-file-prefix branch February 23, 2021 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant