Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DifferenceCompositor ignoring YAML metadata #1564

Merged
merged 1 commit into from Feb 24, 2021

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Feb 24, 2021

I needed to be able to set a standard_name for my difference and noticed that it was being ignored. This pull request fixes that.

  • Tests added

@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #1564 (4c987f0) into master (d556c80) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1564      +/-   ##
==========================================
- Coverage   92.54%   92.54%   -0.01%     
==========================================
  Files         251      251              
  Lines       36761    36763       +2     
==========================================
+ Hits        34022    34023       +1     
- Misses       2739     2740       +1     
Flag Coverage Δ
behaviourtests 4.49% <25.00%> (-0.01%) ⬇️
unittests 92.68% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/composites/__init__.py 88.28% <100.00%> (+0.01%) ⬆️
satpy/tests/test_composites.py 99.87% <100.00%> (+<0.01%) ⬆️
satpy/scene.py 92.07% <0.00%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d556c80...4aa6e0a. Read the comment docs.

@ghost
Copy link

ghost commented Feb 24, 2021

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

@djhoese
Copy link
Member Author

djhoese commented Feb 24, 2021

Retry DeepCode

@djhoese djhoese merged commit feea149 into pytroll:master Feb 24, 2021
@djhoese djhoese deleted the bugfix-difference-compositor branch February 24, 2021 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant