Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DeprecationWarning usage in min_area max_area deprecation #1576

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

ameraner
Copy link
Member

@ameraner ameraner commented Feb 26, 2021

Fix problem of Satpy crashing with warnings.DeprecationWarning wrong usage in min_area max_area deprecation

@codecov
Copy link

codecov bot commented Feb 26, 2021

Codecov Report

Merging #1576 (c17945d) into master (2969c14) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1576   +/-   ##
=======================================
  Coverage   92.54%   92.54%           
=======================================
  Files         251      251           
  Lines       36770    36770           
=======================================
  Hits        34027    34027           
  Misses       2743     2743           
Flag Coverage Δ
behaviourtests 4.50% <ø> (ø)
unittests 92.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/scene.py 91.65% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2969c14...da5e96c. Read the comment docs.

@djhoese
Copy link
Member

djhoese commented Feb 26, 2021

@mraspaud @pnuu @ameraner Do we need a test for this deprecation or do we just trust that it works now?

@mraspaud
Copy link
Member

I'm good with leaving it like this.

@djhoese djhoese changed the title fix DeprecationWarning usage in min_area max_area deprecation Fix DeprecationWarning usage in min_area max_area deprecation Feb 26, 2021
@djhoese djhoese merged commit 385ef94 into pytroll:master Feb 26, 2021
@djhoese
Copy link
Member

djhoese commented Feb 26, 2021

Thanks!

@ameraner ameraner deleted the fix_deprecationwarning branch March 1, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when reaching warnings.DeprecationWarning
3 participants