New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sar-c reader optimization #1580
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1580 +/- ##
==========================================
+ Coverage 92.54% 92.79% +0.25%
==========================================
Files 251 251
Lines 36801 37137 +336
==========================================
+ Hits 34058 34463 +405
+ Misses 2743 2674 -69
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
DeepCode failed to analyze this pull requestSomething went wrong despite trying multiple times, sorry about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after skimming
This PR optimizes the Sar-C reader, among other things by using rioxarray for reading the data.
A simple benchmarking on my laptop reports a reduction of 33% of the memory usage with this PR. The reading is also about 10% faster.