New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GRIB reader for greater flexibility. #1586
Conversation
…l attributes. Also update tests to reflect this and add some additional tests.
Codecov Report
@@ Coverage Diff @@
## master #1586 +/- ##
==========================================
- Coverage 92.84% 92.66% -0.19%
==========================================
Files 251 253 +2
Lines 37193 37199 +6
==========================================
- Hits 34532 34470 -62
- Misses 2661 2729 +68
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Congratulations 🎉. DeepCode analyzed your code in 588.8 seconds and we found no issues. Enjoy a moment of no bugs ☀️. 👉 View analysis in DeepCode’s Dashboard | Configure the bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes. Will merge when tests pass. We should make sure all the other PRs are closed when it is merged.
Currently, the grib reader expects certain keys to be present in the grib file, for example:
For some grib files, such as those from the ERA5 and CAMS datasets, not all keys are present.
modelName
is not present in ERA5 single level datasets.This PR adds some flexibility to the grib reader and will now set missing keys to
unknown
inds_info
rather than raising an error.I have only tested this with ECMWF/ERA/GFS data but it seems to work well with those.
flake8 satpy