Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add file_patterns in file_types with resolution type for satpy_cf_nc reader #1597

Merged
merged 1 commit into from Mar 12, 2021

Conversation

TAlonglong
Copy link
Collaborator

If a instrument provide different spatial resolution, like viirs with M, I and DN Bands this can be stored in one file per resolution type.
This PR adds a file_pattern to match this.

@mraspaud mraspaud added the enhancement code enhancements, features, improvements label Mar 12, 2021
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'm good with that.

@mraspaud mraspaud added this to the v0.26.0 milestone Mar 12, 2021
@codecov
Copy link

codecov bot commented Mar 12, 2021

Codecov Report

Merging #1597 (9228892) into master (c74c396) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1597   +/-   ##
=======================================
  Coverage   92.66%   92.66%           
=======================================
  Files         253      253           
  Lines       37199    37199           
=======================================
  Hits        34470    34470           
  Misses       2729     2729           
Flag Coverage Δ
behaviourtests 4.78% <ø> (ø)
unittests 92.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c74c396...9228892. Read the comment docs.

@mraspaud mraspaud merged commit 64ac75a into pytroll:master Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants