New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MiRS and mimicTPW2_comp readers to sphinx documentation #1599
Conversation
Merge branch 'master' of https://github.com/pytroll/satpy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the mimic reader name is wrong. Otherwise, thanks for updating this.
doc/source/index.rst
Outdated
- `mirs` | ||
- Beta | ||
* - MIMIC Total Precipitable Water Product Reader in NetCDF format | ||
- mimic_TPW2_nc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it looks like the name is actually mimicTPW2_comp
but the python module is mimic_TPW2_nc
. We don't need to change it, but this name is ugly. I didn't think we were going to allow uppercase letters in a reader name. Well here we are I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix it in the index. I can change the uppercase for the reader too, it is up to you. I might be the only one using the mimic reader.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe change the name in another PR. Let's see what @mraspaud and others think about on slack. What does comp
mean by the way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comp
means that I was just getting started with satpy and did not know what to call it. :) Originally, the reader name matched the name mimicTPW2_comp
in the yaml file. I changed the reader name when I reread the documentation, but forgot to change it within the yaml file. FWIW, comp was meant to signal that this is a composite of tpw from the MiRS suite. Someone else mentioned that the sensor and platform names are well named at all and the word product should appear somewhere. This is the opportunity to fix many issues. sensor name, platform name, navigation description and reader name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can pull the mimic information from index.rst until that is resolved, but the MiRS information can remain in the index.rst for the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep both, but just fix the name of the mimic reader in the table so it matches what the reader is actually called (in the YAML, not the python module).
Codecov Report
@@ Coverage Diff @@
## master #1599 +/- ##
==========================================
- Coverage 92.65% 92.34% -0.31%
==========================================
Files 253 254 +1
Lines 37174 37388 +214
==========================================
+ Hits 34442 34527 +85
- Misses 2732 2861 +129
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds the mirs and mimic readers to the index.rst list for documentation.