Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When setting upper_right_corner make sure that all dataset coordinates are flipped #1600

Merged

Conversation

ameraner
Copy link
Member

This PR updates the GEOFlippableFileYAMLReader mechanism to make sure that all dataset coordinates are flipped along with the data, when setting e.g. . global_scene.load(['IR_108'], upper_right_corner='NE').

  • Tests added

@ameraner
Copy link
Member Author

Thanks @TAlonglong for reporting this. @sfinkens @mraspaud FYI

@ghost
Copy link

ghost commented Mar 16, 2021

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

@codecov
Copy link

codecov bot commented Mar 16, 2021

Codecov Report

Merging #1600 (c588c8e) into master (c74c396) will decrease coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1600      +/-   ##
==========================================
- Coverage   92.66%   92.35%   -0.32%     
==========================================
  Files         253      254       +1     
  Lines       37199    37409     +210     
==========================================
+ Hits        34470    34548      +78     
- Misses       2729     2861     +132     
Flag Coverage Δ
behaviourtests 4.78% <0.00%> (-0.01%) ⬇️
unittests 92.48% <100.00%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/yaml_reader.py 96.27% <100.00%> (ø)
satpy/tests/test_yaml_reader.py 99.55% <100.00%> (+0.01%) ⬆️
satpy/tests/test_resample.py 89.26% <0.00%> (-10.39%) ⬇️
satpy/resample.py 80.34% <0.00%> (-9.16%) ⬇️
satpy/writers/awips_tiled.py 82.32% <0.00%> (-0.64%) ⬇️
satpy/tests/test_data_download.py 100.00% <0.00%> (ø)
satpy/conftest.py 71.42% <0.00%> (ø)
satpy/tests/test_composites.py 99.88% <0.00%> (+<0.01%) ⬆️
satpy/tests/test_scene.py 99.44% <0.00%> (+<0.01%) ⬆️
satpy/composites/__init__.py 88.63% <0.00%> (+0.34%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c74c396...c588c8e. Read the comment docs.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this!

@mraspaud mraspaud merged commit 070e699 into pytroll:master Mar 16, 2021
@ameraner ameraner deleted the bugfix-flip_full_dataset_with_coordinates branch March 16, 2021 15:10
@sfinkens
Copy link
Member

Nice work, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants