Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file pattern matching in SEVIRI Native reader #1609

Merged
merged 2 commits into from Mar 22, 2021

Conversation

sfinkens
Copy link
Member

Match algorithm version in filename instead of using a fixed one.

Match algorithm version in filename instead of using a fixed one.
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #1609 (ce170bd) into master (2286d24) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head ce170bd differs from pull request most recent head 27e76d2. Consider uploading reports for the commit 27e76d2 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1609   +/-   ##
=======================================
  Coverage   92.35%   92.35%           
=======================================
  Files         254      254           
  Lines       37409    37422   +13     
=======================================
+ Hits        34548    34561   +13     
  Misses       2861     2861           
Flag Coverage Δ
behaviourtests 4.78% <0.00%> (-0.01%) ⬇️
unittests 92.49% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/tests/reader_tests/test_seviri_l1b_native.py 99.43% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2286d24...27e76d2. Read the comment docs.

Copy link
Member

@ameraner ameraner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of this!

@ghost
Copy link

ghost commented Mar 22, 2021

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix.

@mraspaud mraspaud merged commit 88f0dcb into pytroll:master Mar 22, 2021
@sfinkens sfinkens deleted the fix-seviri-native-pattern-matching branch March 25, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SEVIRI L1.5 native reader does not support files not including 0100 in the file name
4 participants