Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auxiliary download script not using provided data directory #1610

Merged
merged 2 commits into from
Mar 22, 2021

Conversation

djhoese
Copy link
Member

@djhoese djhoese commented Mar 22, 2021

Small typo that stopped the auxiliary download script from customizing the location of data to download. This script was supposed to be so simple it didn't need testing... 馃う

  • Closes #xxxx
  • Tests added

@djhoese djhoese added the bug label Mar 22, 2021
@djhoese djhoese requested a review from mraspaud as a code owner March 22, 2021 15:23
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #1610 (1b2aae7) into master (4928737) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1610      +/-   ##
==========================================
+ Coverage   92.35%   92.38%   +0.03%     
==========================================
  Files         254      254              
  Lines       37409    37421      +12     
==========================================
+ Hits        34548    34571      +23     
+ Misses       2861     2850      -11     
Flag Coverage 螖
behaviourtests 4.78% <6.66%> (-0.01%) 猬囷笍
unittests 92.52% <100.00%> (+0.03%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
satpy/aux_download.py 97.43% <100.00%> (+9.40%) 猬嗭笍
satpy/tests/test_data_download.py 100.00% <100.00%> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 4928737...1b2aae7. Read the comment docs.

@djhoese djhoese changed the title Fix typo in auxiliary download script Fix auxiliary download script not using provided data directory Mar 22, 2021
@ghost
Copy link

ghost commented Mar 22, 2021

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the test.

@mraspaud mraspaud merged commit 3623c03 into pytroll:master Mar 22, 2021
@djhoese djhoese deleted the bugfix-aux-download-script branch March 22, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants