Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SEVIRI Native files without archive header #1612

Merged
merged 4 commits into from Mar 24, 2021

Conversation

sfinkens
Copy link
Member

@sfinkens sfinkens commented Mar 23, 2021

This PR adds support for reading SEVIRI Native files without ASCII archive header. These are provided to users of the European Weather Cloud. The header is only included if data are ordered through the EUMETSAT data center.

  • Tests added
  • Passes flake8 satpy

@sfinkens sfinkens requested review from sjoro and ameraner March 23, 2021 10:12
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #1612 (f9b8686) into master (3623c03) will increase coverage by 0.00%.
The diff coverage is 95.91%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1612   +/-   ##
=======================================
  Coverage   92.38%   92.39%           
=======================================
  Files         254      254           
  Lines       37434    37455   +21     
=======================================
+ Hits        34584    34605   +21     
  Misses       2850     2850           
Flag Coverage Δ
behaviourtests 4.77% <0.00%> (-0.01%) ⬇️
unittests 92.52% <95.91%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/seviri_l1b_native.py 79.56% <80.00%> (+0.45%) ⬆️
satpy/readers/seviri_l1b_native_hdr.py 100.00% <100.00%> (ø)
satpy/tests/reader_tests/test_seviri_l1b_native.py 99.44% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3623c03...f9b8686. Read the comment docs.

@ghost
Copy link

ghost commented Mar 23, 2021

DeepCode failed to analyze this pull request

Something went wrong despite trying multiple times, sorry about that.
Please comment this pull request with "Retry DeepCode" to manually retry, or contact us so that a human can look into the issue.

Copy link
Member

@ameraner ameraner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for this, very useful! Just tested it with our archived data, works like a charm :)

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit 3917c34 into pytroll:master Mar 24, 2021
@mraspaud mraspaud added component:readers enhancement code enhancements, features, improvements labels Mar 24, 2021
@sfinkens
Copy link
Member Author

sfinkens commented Mar 25, 2021

Glad to hear, thanks for testing @ameraner !

@sfinkens sfinkens deleted the feature-seviri-native-headerless branch March 25, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:readers enhancement code enhancements, features, improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants