Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize vii dims #1613

Merged
merged 3 commits into from Mar 25, 2021
Merged

Standardize vii dims #1613

merged 3 commits into from Mar 25, 2021

Conversation

ninahakansson
Copy link
Contributor

@ninahakansson ninahakansson commented Mar 23, 2021 •
edited

Dimensions are normally named 'y', 'x' in satpy.
And 'y' should be the first dim.

  • Closes #xxxx
  • Tests added

Nina.Hakansson added 2 commits March 23, 2021 16:34
Standardize vii dims
39b05c8 
Dimensions are normally named 'y', 'x' in satpy.
And y should be the first dim.
keep the transposed data
375beba
ninahakansson pushed a commit to ninahakansson/level1c4pps that referenced this pull request Mar 24, 2021
Handle y,x dimension names also for metimage
7c4198d 
The dimensions for vii are planned to be standardized to the normal
satpy y, x. Both name and order will be changed.

pytroll/satpy#1613
@ninahakansson ninahakansson mentioned this pull request Mar 24, 2021
Merged
@codecov
Copy link

codecov bot commented Mar 24, 2021 •
edited

Codecov Report

Merging #1613 (090dcbd) into master (2286d24) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1613      +/-   ##
==========================================
+ Coverage   92.35%   92.38%   +0.03%     
==========================================
  Files         254      254              
  Lines       37409    37447      +38     
==========================================
+ Hits        34548    34597      +49     
+ Misses       2861     2850      -11
Flag Coverage Δ
behaviourtests 4.77% <0.00%> (-0.01%) ⬇️
unittests 92.52% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/vii_base_nc.py 94.54% <100.00%> (+0.37%) ⬆️
satpy/tests/reader_tests/test_vii_base_nc.py 98.78% <100.00%> (+0.04%) ⬆️
satpy/tests/test_data_download.py 100.00% <0.00%> (ø)
satpy/tests/reader_tests/test_seviri_l1b_native.py 99.43% <0.00%> (+0.02%) ⬆️
satpy/aux_download.py 97.43% <0.00%> (+9.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2286d24...090dcbd. Read the comment docs.

@ninahakansson ninahakansson marked this pull request as ready for review March 24, 2021 10:42
mraspaud
mraspaud approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the handy function!

@mraspaud mraspaud requested a review from sjoro March 25, 2021 05:58
sjoro
sjoro approved these changes Mar 25, 2021
View reviewed changes
Copy link
Collaborator

@sjoro sjoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mraspaud mraspaud merged commit c33e8cd into pytroll:master Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mraspaud mraspaud mraspaud approved these changes

@sjoro sjoro sjoro approved these changes

@djhoese djhoese Awaiting requested review from djhoese

Assignees

@ninahakansson ninahakansson

Labels
bug component:readers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ninahakansson @mraspaud @sjoro