New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the reinhard enhancements #1623
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1623 +/- ##
=======================================
Coverage 92.60% 92.60%
=======================================
Files 258 258
Lines 37716 37739 +23
=======================================
+ Hits 34927 34950 +23
Misses 2789 2789
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Should it be documented somewhere? I suppose we don't really have a lot of enhancement documentation.
Also, I'm wondering if this should be wrapped in a single function that gets with map_blocks? We've seen in other areas that limiting the number of tasks that dask has to deal with can improve the performance. Just an idea, not a requirement for merge.
I'm going to merge this as it is because: I think if we want to limit the number of dask tasks, it should be done at a higher level, for example in the code that calls the enhancements. Otherwise we will end up with many map_blocks everywhere that will lower readability and maintenability I think. |
That was the intention (at least a little bit) with the |
This PR adds a reinhard-based tonemapping enhancement.
An example on an Himawari 8 True Color image
Reinhard:
Cira stretch