New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for transposed angles in safe-msi reader #1628
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1628 +/- ##
==========================================
+ Coverage 92.58% 92.84% +0.26%
==========================================
Files 258 259 +1
Lines 38345 38370 +25
==========================================
+ Hits 35501 35625 +124
+ Misses 2844 2745 -99
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Congratulations 🎉. DeepCode analyzed your code in 3.822 seconds and we found no issues. Enjoy a moment of no bugs ☀️. 👉 View analysis in DeepCode’s Dashboard | Configure the bot👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin. |
@djhoese this is ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small comment and just wondering if it is worth it to replace some of the long XML in the tests with python string formatting since it seems a lot of the lines/nans are repeated? Not a big deal. Merge when you feel ready.
satpy/readers/msi_safe.py
Outdated
@staticmethod | ||
def _calibrate(proj): | ||
proj = proj.where(proj > 0) | ||
# FIXME: get this from MTD_MSIL1C.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're always telling me...this should probably be made into an issue right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep thanks, creating issue now
As for the xml, I'd rather keep it as close as possible to the original data, for readability. |
This PRs fixed the broken angles interpolation in the safe-msi (sentinel 2) reader