Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for transposed angles in safe-msi reader #1628

Merged
merged 11 commits into from Jun 15, 2021

Conversation

mraspaud
Copy link
Member

@mraspaud mraspaud commented Apr 1, 2021

This PRs fixed the broken angles interpolation in the safe-msi (sentinel 2) reader

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #1628 (d3519c3) into main (b415e9b) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1628      +/-   ##
==========================================
+ Coverage   92.58%   92.84%   +0.26%     
==========================================
  Files         258      259       +1     
  Lines       38345    38370      +25     
==========================================
+ Hits        35501    35625     +124     
+ Misses       2844     2745      -99     
Flag Coverage Δ
behaviourtests 4.83% <0.00%> (-0.01%) ⬇️
unittests 93.39% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
satpy/readers/msi_safe.py 76.33% <100.00%> (+74.08%) ⬆️
satpy/tests/reader_tests/test_msi_safe.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b415e9b...d3519c3. Read the comment docs.

@mraspaud mraspaud added this to To do in PCW Spring 2021 May 17, 2021
@mraspaud mraspaud requested a review from djhoese as a code owner June 14, 2021 10:44
setup.py Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Jun 14, 2021

Congratulations 🎉. DeepCode analyzed your code in 3.822 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

👉 The DeepCode service and API will be deprecated in August, 2021. Here is the information how to migrate. Thank you for using DeepCode 🙏 ❤️ !

If you are using our plugins, you might be interested in their successors: Snyk's JetBrains plugin and Snyk's VS Code plugin.

@coveralls
Copy link

coveralls commented Jun 14, 2021

Coverage Status

Coverage increased (+0.3%) to 93.335% when pulling d3519c3 on mraspaud:fix-msi-angles into b415e9b on pytroll:main.

@mraspaud
Copy link
Member Author

@djhoese this is ready for review

Copy link
Member

@djhoese djhoese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small comment and just wondering if it is worth it to replace some of the long XML in the tests with python string formatting since it seems a lot of the lines/nans are repeated? Not a big deal. Merge when you feel ready.

@staticmethod
def _calibrate(proj):
proj = proj.where(proj > 0)
# FIXME: get this from MTD_MSIL1C.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're always telling me...this should probably be made into an issue right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep thanks, creating issue now

PCW Spring 2021 automation moved this from To do to Reviewer approved Jun 14, 2021
@mraspaud
Copy link
Member Author

As for the xml, I'd rather keep it as close as possible to the original data, for readability.

@mraspaud mraspaud merged commit 96adc4d into pytroll:main Jun 15, 2021
PCW Spring 2021 automation moved this from Reviewer approved to Done Jun 15, 2021
@mraspaud mraspaud deleted the fix-msi-angles branch June 15, 2021 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
4 participants