New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore raw metadata when combining metadata #1663
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1663 +/- ##
=======================================
Coverage 92.65% 92.65%
=======================================
Files 258 258
Lines 37948 37952 +4
=======================================
+ Hits 35161 35165 +4
Misses 2787 2787
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. I had a couple suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Why did travis and appveyor suddenly show up again in this PR? Did you have an old master/main branch that you based this branch off of? |
Hmm, that is strange. The branch is based on 6df2f10 which was a couple commits before master was renamed to main (did that in my fork, too) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks a lot for your help fixing this!
When combining metadata from multiple datasets, ignore the
raw_metadata
attribute. Usually these are nested dictionaries containing numpy arrays. You could compare them usingnp.testing.assert_equal
, butSo I'd say it's not worth the effort.